👣Tutorial 47: The Risk of Forgetting a Withdrawal Mechanism in Smart Contracts

Book an audit with Zokyo

A critical yet sometimes overlooked issue in smart contract development is the failure to include a withdrawal mechanism for Ether or other tokens that may accumulate in the contract. When a contract handles financial transactions, such as buying or distributing tokens, it may unintentionally retain some portion of the funds. Without a method to withdraw these remaining funds, they become stuck in the contract, inaccessible to any party. This creates inefficiencies and potential losses for users or the protocol.

The Problem: Ether or Tokens Get Stuck in the Contract

Smart contracts that manage funds often distribute portions of the incoming Ether or tokens to different recipients based on predefined rules or percentages. For example, a contract might send a percentage to a rewards pool, another portion to a treasury, and distribute the remainder among other parties. However, in cases where a contract rounds down small fractions of Ether or token values, or when the distribution logic fails to account for all possibilities, some Ether can remain locked inside the contract.

This leftover Ether or tokens may seem negligible at first, but over time, as more transactions are processed, the unclaimed amounts can accumulate significantly. Without a way to withdraw these funds, they become permanently locked in the contract, rendering them unusable.

Example of the Issue

Consider a scenario where a smart contract distributes incoming Ether to various parties. After calculating and distributing the majority of the funds, a small remainder is left inside the contract due to the specifics of the division. Since there is no mechanism in place to withdraw this remainder, the Ether stays in the contract indefinitely.

For instance, if a contract processes a token sale and distributes 97.5% of the proceeds to various parties, the remaining 2.5% might get stuck in the contract if there is no explicit mechanism for handling this remainder. Over time, with multiple transactions, this small percentage can add up to a significant amount.

Impact of Stuck Funds

The inability to withdraw stuck funds can have several negative consequences:

1. Inefficiency: Funds that remain locked in a contract cannot be utilized by the protocol or its users. This results in inefficiencies, as capital that could have been used for growth or rewards is effectively frozen.

2. User Confusion: Users may assume that their funds are lost or irretrievable, leading to frustration and a loss of trust in the system.

3. Economic Loss: In the case of large-scale contracts that process many transactions, the cumulative value of stuck funds can be significant, leading to potential economic losses for the protocol or its stakeholders.

4. Security Risks: Stuck funds can become a target for attackers, who may attempt to exploit vulnerabilities in the contract to claim the funds. Although the funds are technically inaccessible, attackers may search for flaws that allow them to extract the trapped Ether or tokens.

Mitigation: Implementing a Withdrawal Mechanism

To prevent funds from being stuck in a smart contract, developers should ensure that every contract holding funds includes a withdrawal mechanism. This mechanism should allow the contract owner, or another authorized party, to retrieve any excess funds that remain after the primary distribution has been made.

Key considerations when designing a withdrawal function:

• Authorized Access: Only specific roles, such as the contract owner or an administrator, should be allowed to trigger withdrawals. This prevents unauthorized access to the remaining funds.

• Fallback Distribution: If the contract cannot determine where the remainder of the funds should go, a fallback option should send the funds to a safe address, such as the treasury or another trusted recipient.

• Reentrancy Protection: To prevent reentrancy attacks, which are a common vulnerability in withdrawal functions, the contract should use a checks-effects-interactions pattern or non-reentrant modifiers.